Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meeting notes for interface inheritance meeting #2144

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Nov 16, 2022

Description

Adds the notes for the meeting held on 16th Nov, 2022, to discuss details of interface inheritance.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Documentation Improvements or additions to documentation label Nov 16, 2022
@SupunS SupunS self-assigned this Nov 16, 2022
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent requested a review from a team November 16, 2022 21:07
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #2144 (85309b8) into master (2926beb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2144   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files         307      307           
  Lines       64026    64026           
=======================================
  Hits        49902    49902           
  Misses      12331    12331           
  Partials     1793     1793           
Flag Coverage Δ
unittests 77.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 2926beb
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2116µs ± 6%116µs ± 4%~(p=0.620 n=7+7)
ContractInterfaceFungibleToken-240.7µs ± 6%40.0µs ± 6%~(p=0.295 n=6+7)
InterpretRecursionFib-22.30ms ± 4%2.29ms ± 6%~(p=0.902 n=7+7)
NewInterpreter/new_interpreter-21.08µs ± 5%1.04µs ± 4%~(p=0.100 n=7+6)
NewInterpreter/new_sub-interpreter-2576ns ± 4%580ns ± 6%~(p=0.945 n=6+7)
ParseArray-27.33ms ± 5%7.51ms ± 1%~(p=0.065 n=6+6)
ParseDeploy/byte_array-211.2ms ± 6%11.5ms ± 5%~(p=0.383 n=7+7)
ParseDeploy/decode_hex-21.17ms ± 8%1.13ms ± 3%~(p=0.128 n=7+7)
ParseFungibleToken/With_memory_metering-2177µs ± 5%178µs ± 4%~(p=0.620 n=7+7)
ParseFungibleToken/Without_memory_metering-2140µs ± 6%143µs ± 9%~(p=0.620 n=7+7)
ParseInfix-26.50µs ± 6%6.48µs ± 4%~(p=0.805 n=7+7)
QualifiedIdentifierCreation/One_level-22.19ns ± 7%2.08ns ± 2%~(p=0.221 n=7+6)
QualifiedIdentifierCreation/Three_levels-2132ns ± 4%129ns ± 5%~(p=0.165 n=7+7)
RuntimeFungibleTokenTransfer-2724µs ± 5%611µs ±22%−15.70%(p=0.014 n=6+7)
RuntimeResourceDictionaryValues-24.89ms ± 7%5.08ms ± 3%~(p=0.138 n=7+6)
RuntimeScriptNoop-219.3µs ±38%18.9µs ±44%~(p=1.000 n=7+7)
SuperTypeInference/arrays-2296ns ± 4%284ns ± 4%−4.16%(p=0.034 n=7+7)
SuperTypeInference/composites-2126ns ±21%122ns ± 8%~(p=0.216 n=7+7)
SuperTypeInference/integers-290.1ns ± 0%80.6ns ± 4%−10.57%(p=0.002 n=6+6)
ValueIsSubtypeOfSemaType-285.8ns ± 8%85.9ns ± 6%~(p=0.779 n=7+7)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-251.0kB ± 0%51.0kB ± 0%~(all equal)
ContractInterfaceFungibleToken-224.7kB ± 0%24.7kB ± 0%~(all equal)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(p=0.286 n=7+7)
NewInterpreter/new_interpreter-2752B ± 0%752B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2200B ± 0%200B ± 0%~(all equal)
ParseArray-22.73MB ± 3%2.74MB ± 3%~(p=0.902 n=7+7)
ParseDeploy/byte_array-24.13MB ± 3%4.16MB ± 2%~(p=0.826 n=7+7)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=0.327 n=7+7)
ParseFungibleToken/With_memory_metering-229.3kB ± 0%29.4kB ± 0%~(p=0.538 n=6+7)
ParseFungibleToken/Without_memory_metering-229.4kB ± 0%29.3kB ± 0%~(p=0.434 n=7+6)
ParseInfix-21.92kB ± 0%1.92kB ± 0%~(p=0.832 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeFungibleTokenTransfer-2103kB ± 1%102kB ± 1%~(p=0.710 n=7+7)
RuntimeResourceDictionaryValues-22.28MB ± 0%2.28MB ± 0%~(p=0.165 n=7+7)
RuntimeScriptNoop-28.50kB ± 0%8.51kB ± 1%~(p=0.873 n=6+7)
SuperTypeInference/arrays-296.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-20.00B 0.00B ~(all equal)
SuperTypeInference/integers-20.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2920 ± 0%920 ± 0%~(all equal)
ContractInterfaceFungibleToken-2444 ± 0%444 ± 0%~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-24.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-259.6k ± 0%59.6k ± 0%~(p=1.315 n=7+6)
ParseDeploy/byte_array-289.4k ± 0%89.4k ± 0%~(p=1.000 n=7+7)
ParseDeploy/decode_hex-264.0 ± 0%64.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-2779 ± 0%779 ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-2779 ± 0%779 ± 0%~(all equal)
ParseInfix-248.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeFungibleTokenTransfer-22.01k ± 0%2.01k ± 0%~(all equal)
RuntimeResourceDictionaryValues-237.0k ± 0%37.0k ± 0%~(p=0.878 n=7+7)
RuntimeScriptNoop-2137 ± 0%137 ± 0%~(all equal)
SuperTypeInference/arrays-23.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-20.00 0.00 ~(all equal)
SuperTypeInference/integers-20.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

@SupunS SupunS merged commit b19393f into master Nov 16, 2022
@SupunS SupunS deleted the supun/meeting-notes branch November 17, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants