Improve sema

[turbolent]

Description

Add type assertions and make naming for field and function name constants consistent.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[codecov]

Codecov Report

Merging #2166 (1d30a85) into master (e2f0bc5) will increase coverage by 0.01%.
The diff coverage is 99.21%.

@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage   77.68%   77.69%   +0.01%     
==========================================
  Files         308      308              
  Lines       64246    64302      +56     
==========================================
+ Hits        49910    49961      +51     
- Misses      12600    12605       +5     
  Partials     1736     1736              

Flag	Coverage Δ
unittests	77.69% <99.21%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
runtime/sema/simple_type.go	96.15% <ø> (ø)
runtime/stdlib/test.go	38.19% <0.00%> (ø)
runtime/convertValues.go	83.00% <100.00%> (ø)
runtime/interpreter/account.go	92.66% <100.00%> (ø)
runtime/interpreter/accountinbox.go	73.07% <100.00%> (ø)
runtime/interpreter/accountkey.go	100.00% <100.00%> (ø)
runtime/interpreter/accountkeys.go	74.19% <100.00%> (ø)
runtime/interpreter/value.go	68.96% <100.00%> (ø)
runtime/interpreter/value_publickey.go	100.00% <100.00%> (ø)
runtime/sema/authaccount_type.go	100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit de28ef3
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
CheckContractInterfaceFungibleTokenConformance-2	115µs ± 2%	114µs ± 1%	~	(p=0.534 n=7+6)
ContractInterfaceFungibleToken-2	39.0µs ± 1%	38.8µs ± 1%	~	(p=0.620 n=7+7)
InterpretRecursionFib-2	2.36ms ± 1%	2.37ms ± 2%	~	(p=0.731 n=6+7)
NewInterpreter/new_interpreter-2	1.11µs ± 1%	1.11µs ± 0%	~	(p=1.000 n=6+6)
NewInterpreter/new_sub-interpreter-2	598ns ± 2%	598ns ± 2%	~	(p=1.000 n=7+6)
ParseArray-2	7.96ms ± 1%	8.02ms ± 2%	~	(p=0.132 n=6+6)
ParseDeploy/byte_array-2	12.2ms ± 4%	12.1ms ± 4%	~	(p=0.805 n=7+7)
ParseDeploy/decode_hex-2	1.22ms ± 3%	1.21ms ± 1%	~	(p=0.445 n=7+6)
ParseFungibleToken/With_memory_metering-2	187µs ± 1%	187µs ± 3%	~	(p=0.620 n=7+7)
ParseFungibleToken/Without_memory_metering-2	147µs ± 3%	147µs ± 1%	~	(p=1.000 n=7+7)
ParseInfix-2	6.95µs ± 3%	6.90µs ± 1%	~	(p=0.945 n=7+6)
QualifiedIdentifierCreation/One_level-2	2.35ns ± 0%	2.35ns ± 1%	~	(p=0.775 n=6+7)
QualifiedIdentifierCreation/Three_levels-2	136ns ± 1%	135ns ± 1%	~	(p=0.731 n=7+7)
RuntimeFungibleTokenTransfer-2	618µs ±24%	668µs ±24%	~	(p=0.710 n=7+7)
RuntimeResourceDictionaryValues-2	5.21ms ± 1%	5.20ms ± 3%	~	(p=0.366 n=6+7)
RuntimeScriptNoop-2	17.9µs ±43%	20.8µs ±30%	~	(p=0.805 n=7+7)
SuperTypeInference/arrays-2	313ns ± 3%	309ns ± 1%	~	(p=0.214 n=7+6)
SuperTypeInference/composites-2	131ns ± 0%	131ns ± 0%	~	(p=0.796 n=7+6)
SuperTypeInference/integers-2	89.6ns ± 0%	89.6ns ± 0%	~	(p=0.628 n=7+6)
ValueIsSubtypeOfSemaType-2	91.9ns ± 2%	91.4ns ± 0%	~	(p=0.639 n=7+5)
	alloc/op		delta
CheckContractInterfaceFungibleTokenConformance-2	49.7kB ± 0%	49.7kB ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	24.0kB ± 0%	24.0kB ± 0%	~	(all equal)
InterpretRecursionFib-2	1.00MB ± 0%	1.00MB ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	752B ± 0%	752B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-2	2.72MB ± 3%	2.74MB ± 3%	~	(p=0.383 n=7+7)
ParseDeploy/byte_array-2	4.14MB ± 3%	4.14MB ± 3%	~	(p=0.902 n=7+7)
ParseDeploy/decode_hex-2	214kB ± 0%	214kB ± 0%	~	(p=0.777 n=7+7)
ParseFungibleToken/With_memory_metering-2	29.2kB ± 0%	29.2kB ± 0%	~	(p=0.145 n=7+7)
ParseFungibleToken/Without_memory_metering-2	29.2kB ± 0%	29.2kB ± 0%	~	(p=0.262 n=7+7)
ParseInfix-2	1.91kB ± 0%	1.92kB ± 0%	~	(p=0.867 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-2	102kB ± 1%	103kB ± 1%	~	(p=0.535 n=7+7)
RuntimeResourceDictionaryValues-2	2.28MB ± 0%	2.28MB ± 0%	~	(p=0.710 n=7+7)
RuntimeScriptNoop-2	8.44kB ± 0%	8.44kB ± 0%	~	(p=0.171 n=7+7)
SuperTypeInference/arrays-2	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-2	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-2	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-2	48.0B ± 0%	48.0B ± 0%	~	(all equal)
	allocs/op		delta
CheckContractInterfaceFungibleTokenConformance-2	815 ± 0%	815 ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	388 ± 0%	388 ± 0%	~	(all equal)
InterpretRecursionFib-2	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	13.0 ± 0%	13.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-2	59.6k ± 0%	59.6k ± 0%	~	(p=0.592 n=7+7)
ParseDeploy/byte_array-2	89.4k ± 0%	89.4k ± 0%	~	(p=0.592 n=7+7)
ParseDeploy/decode_hex-2	64.0 ± 0%	64.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-2	779 ± 0%	779 ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-2	779 ± 0%	779 ± 0%	~	(all equal)
ParseInfix-2	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-2	1.99k ± 0%	1.99k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-2	36.9k ± 0%	36.9k ± 0%	~	(p=0.302 n=7+7)
RuntimeScriptNoop-2	132 ± 0%	132 ± 0%	~	(all equal)
SuperTypeInference/arrays-2	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-2	0.00	0.00	~	(all equal)
SuperTypeInference/integers-2	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-2	1.00 ± 0%	1.00 ± 0%	~	(all equal)