Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.31] Check cyclic storage references during export #2408

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Mar 30, 2023

Description

Port of https://github.com/dapperlabs/cadence-internal/pull/117


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Mar 30, 2023
@SupunS SupunS added the Bugfix label Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #2408 (a04c614) into v0.31.5-account-linking-improved-pragma (5e957a9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                           Coverage Diff                            @@
##           v0.31.5-account-linking-improved-pragma    #2408   +/-   ##
========================================================================
  Coverage                                    77.71%   77.72%           
========================================================================
  Files                                          309      309           
  Lines                                        65852    65859    +7     
========================================================================
+ Hits                                         51179    51189   +10     
+ Misses                                       12892    12890    -2     
+ Partials                                      1781     1780    -1     
Flag Coverage Δ
unittests 77.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/value.go 68.88% <ø> (ø)
runtime/convertValues.go 83.10% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:v0.31.5-account-linking-improved-pragma commit 5e957a9
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent changed the title Check cyclic storage references during export [v0.31] Check cyclic storage references during export Mar 30, 2023
@SupunS SupunS merged commit ee85b38 into v0.31.5-account-linking-improved-pragma Mar 30, 2023
@SupunS SupunS deleted the supun/v0.31.5-account-linking-improved-pragma-patch.1 branch July 11, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants