Improve cadence.Path #2427
Merged
Improve cadence.Path #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
added
Bugfix
Improvement
Go API Breaking Change
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 79bba60 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2427 +/- ##
==========================================
- Coverage 78.60% 78.60% -0.01%
==========================================
Files 316 316
Lines 68848 68854 +6
==========================================
+ Hits 54118 54120 +2
- Misses 12928 12931 +3
- Partials 1802 1803 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SupunS
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Triggered by https://dapperlabs.slack.com/archives/C0447MS42KX/p1680724003020649
Improve type of
cadence.Path.domain: Instead of stringly-typing, use the enum. That prevents representing invalid path valuesIn the
cadence.Pathconstructor function, ensure the domain is known. This fixes a bug where a path with an invalid domain was not validated. e.g. see https://testnet.flowscan.org/transaction/c3eb670d0ac98d8a5ffda6e4be4f5b1d343d7829dab1eb5b610f93c016f6640b/scriptInstead of always returning the supertype
Pathfor allcadence.Pathvalues, return an appropriate subtype, depending on the domain.The CLI uses the return value when preparing a deployment transaction.
When a user would pass e.g. a storage path as an argument to a contract initializer which expects a
StoragePath, the CLI would prepare a transaction where the transaction parameter is justPath.See e.g https://testnet.flowscan.org/transaction/e7419fd3c7b5ad429cedd23af2ec410ed4f0df63a84069034c6958b1efbf3321
masterbranchFiles changedin the Github PR explorer