Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release notes configuration #2435

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

turbolent
Copy link
Member

Description

The GitHub issue labels for breaking changes have been renamed and additional breaking changes labels have been introduced.

Fix the release notes configuration and add the new labels to it.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from j1010001 April 12, 2023 16:06
@turbolent turbolent requested a review from SupunS as a code owner April 12, 2023 16:06
@turbolent turbolent self-assigned this Apr 12, 2023
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 1541525
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2112µs ± 0%114µs ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-238.5µs ± 0%38.7µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-2331ns ± 0%329ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-252.5ns ± 0%52.5ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-22.50ms ± 0%2.51ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-21.22µs ± 0%1.09µs ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-2559ns ± 0%561ns ± 0%~(p=1.000 n=1+1)
ParseArray-27.82ms ± 0%7.59ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-211.7ms ± 0%11.5ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-21.21ms ± 0%1.21ms ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-2184µs ± 0%200µs ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-2146µs ± 0%143µs ± 0%~(p=1.000 n=1+1)
ParseInfix-27.15µs ± 0%7.04µs ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-22.41ns ± 0%2.81ns ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-2127ns ± 0%121ns ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-25.21ms ± 0%5.20ms ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-27.83µs ± 0%7.74µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-2299ns ± 0%297ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-2132ns ± 0%132ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-298.9ns ± 0%99.3ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-290.0ns ± 0%92.8ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-249.2kB ± 0%49.2kB ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-223.3kB ± 0%23.3kB ± 0%~(all equal)
ExportType/composite_type-2136B ± 0%136B ± 0%~(all equal)
ExportType/simple_type-20.00B 0.00B ~(all equal)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(all equal)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2200B ± 0%200B ± 0%~(all equal)
ParseArray-22.65MB ± 0%2.65MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-24.26MB ± 0%4.09MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-228.9kB ± 0%28.9kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-228.9kB ± 0%28.9kB ± 0%~(all equal)
ParseInfix-21.92kB ± 0%1.92kB ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeResourceDictionaryValues-22.28MB ± 0%2.28MB ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-22.70kB ± 0%2.70kB ± 0%~(all equal)
SuperTypeInference/arrays-296.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-20.00B 0.00B ~(all equal)
SuperTypeInference/integers-20.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2806 ± 0%806 ± 0%~(all equal)
ContractInterfaceFungibleToken-2370 ± 0%370 ± 0%~(all equal)
ExportType/composite_type-23.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-20.00 0.00 ~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-24.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-259.6k ± 0%59.6k ± 0%~(all equal)
ParseDeploy/byte_array-289.4k ± 0%89.4k ± 0%~(all equal)
ParseDeploy/decode_hex-263.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseInfix-248.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeResourceDictionaryValues-236.9k ± 0%36.9k ± 0%~(all equal)
RuntimeScriptNoop-243.0 ± 0%43.0 ± 0%~(all equal)
SuperTypeInference/arrays-23.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-20.00 0.00 ~(all equal)
SuperTypeInference/integers-20.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2435 (0939559) into master (1541525) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2435   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files         315      315           
  Lines       68892    68892           
=======================================
  Hits        54137    54137           
  Misses      12946    12946           
  Partials     1809     1809           
Flag Coverage Δ
unittests 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@turbolent turbolent merged commit fbaf53a into master Apr 12, 2023
13 of 16 checks passed
@turbolent turbolent deleted the bastian/fix-release-notes-config branch April 12, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants