Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.31] Check for potential resource loss in reference expression #2436

Conversation

turbolent
Copy link
Member

Description

Port of dapperlabs/cadence-internal#118


  • Targeted PR against master v0.31 branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2436 (7fcf584) into v0.31.5-account-linking-improved-pragma (ee85b38) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                           Coverage Diff                            @@
##           v0.31.5-account-linking-improved-pragma    #2436   +/-   ##
========================================================================
  Coverage                                    77.72%   77.72%           
========================================================================
  Files                                          309      309           
  Lines                                        65859    65861    +2     
========================================================================
+ Hits                                         51189    51191    +2     
  Misses                                       12890    12890           
  Partials                                      1780     1780           
Flag Coverage Δ
unittests 77.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/check_reference_expression.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@turbolent turbolent merged commit 827b291 into v0.31.5-account-linking-improved-pragma Apr 12, 2023
11 of 13 checks passed
@turbolent turbolent deleted the bastian/v0.31.5-account-linking-improved-pragma-patch.2 branch April 12, 2023 16:42
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:v0.31.5-account-linking-improved-pragma commit ee85b38
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants