Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ordering comparison (<, <=, >, >=) to String #2470

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

darkdrag00nv2
Copy link
Contributor

@darkdrag00nv2 darkdrag00nv2 commented Apr 25, 2023

Closes #2276

Description

Adds comparison support for String


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #2470 (cc9ace8) into master (18682d6) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
- Coverage   78.25%   78.23%   -0.03%     
==========================================
  Files         325      325              
  Lines       72538    72574      +36     
==========================================
+ Hits        56766    56778      +12     
- Misses      13682    13702      +20     
- Partials     2090     2094       +4     
Flag Coverage Δ
unittests 78.23% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/string_type.go 95.87% <ø> (ø)
runtime/interpreter/value.go 69.45% <33.33%> (-0.11%) ⬇️

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@turbolent turbolent self-assigned this Apr 27, 2023
@turbolent turbolent merged commit 43cac87 into onflow:master Apr 27, 2023
9 of 14 checks passed
@darkdrag00nv2 darkdrag00nv2 deleted the string_ordering branch April 28, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend ordering comparisons (< , <=, etc) to support container types
3 participants