-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Address.fromString #2491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdrag00nv2
requested review from
turbolent,
SupunS,
dsainati1 and
joshuahannan
as code owners
May 6, 2023 10:02
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
===========================================
+ Coverage 0 78.35% +78.35%
===========================================
Files 0 327 +327
Lines 0 73039 +73039
===========================================
+ Hits 0 57230 +57230
- Misses 0 13710 +13710
- Partials 0 2099 +2099
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dsainati1
requested changes
May 8, 2023
turbolent
reviewed
May 8, 2023
Co-authored-by: Bastian Müller <bastian@turbolent.com>
dsainati1
approved these changes
May 8, 2023
SupunS
approved these changes
May 8, 2023
Co-authored-by: Daniel Sainati <sainatidaniel@gmail.com>
turbolent
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2154
Work towards onflow/developer-grants#179
Description
Add
Address.fromString
method.master
branchFiles changed
in the Github PR explorer