Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Address.fromString #2491

Merged
merged 7 commits into from
May 8, 2023
Merged

Conversation

darkdrag00nv2
Copy link
Contributor

@darkdrag00nv2 darkdrag00nv2 commented May 6, 2023

Closes #2154
Work towards onflow/developer-grants#179

Description

Add Address.fromString method.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2491 (910bdde) into master (68b2291) will increase coverage by 78.35%.
The diff coverage is 90.90%.

@@             Coverage Diff             @@
##           master    #2491       +/-   ##
===========================================
+ Coverage        0   78.35%   +78.35%     
===========================================
  Files           0      327      +327     
  Lines           0    73039    +73039     
===========================================
+ Hits            0    57230    +57230     
- Misses          0    13710    +13710     
- Partials        0     2099     +2099     
Flag Coverage Δ
unittests 78.35% <90.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/interpreter.go 89.87% <ø> (ø)
runtime/interpreter/value.go 69.46% <80.00%> (ø)
runtime/common/address.go 100.00% <100.00%> (ø)
runtime/sema/type.go 89.44% <100.00%> (ø)

... and 323 files with indirect coverage changes

docs/language/values-and-types.mdx Outdated Show resolved Hide resolved
runtime/interpreter/interpreter.go Outdated Show resolved Hide resolved
docs/language/values-and-types.mdx Outdated Show resolved Hide resolved
runtime/interpreter/value.go Outdated Show resolved Hide resolved
docs/language/values-and-types.mdx Outdated Show resolved Hide resolved
docs/language/values-and-types.mdx Outdated Show resolved Hide resolved
runtime/interpreter/interpreter.go Outdated Show resolved Hide resolved
runtime/interpreter/interpreter.go Outdated Show resolved Hide resolved
runtime/interpreter/value.go Outdated Show resolved Hide resolved
runtime/sema/type.go Outdated Show resolved Hide resolved
runtime/sema/type.go Outdated Show resolved Hide resolved
Co-authored-by: Daniel Sainati <sainatidaniel@gmail.com>
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent self-assigned this May 8, 2023
@turbolent turbolent merged commit d47ff5d into onflow:master May 8, 2023
9 of 14 checks passed
@darkdrag00nv2 darkdrag00nv2 deleted the from_string_2154 branch May 9, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fromString conversion function to Address type
4 participants