Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capability controllers #2501

Merged
merged 187 commits into from
May 26, 2023
Merged

Capability controllers #2501

merged 187 commits into from
May 26, 2023

Conversation

turbolent
Copy link
Member

Work towards #2091

Description

Merge the Cap Cons feature to master.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Naomi Liu and others added 30 commits March 31, 2023 12:39
@turbolent
add capcon codegen boilerplate
bef0bdc
@turbolent
generate capcon type, add capcon type mask
8d1fb21
@turbolent
add capcon typeannotation
1cda300
@turbolent
add capcon type to getsupertypefromuppermask
c64774e
@turbolent
begin value implementation for capcon type
103d828
@turbolent
run go generate
c1c2d90
@turbolent
remove cbor encoding for capcons, continue implementing value
2be3613
@turbolent
add TargetPath field and stubs
757e255
@turbolent
switch isRevoked field to be a getter function
302eaa7
@turbolent
change formatting of capcon type
848316d
@turbolent
switch capcon value to be simplecomposite type, add it to checker types
0f92488
@turbolent
start writing capcon tests
1f2825d
@turbolent
add todo msg
f858a82
@turbolent
add capcontypetag back to anystruct type tag
7bfb2f3
@turbolent
remove capabilitycontrollervalue
2388e30
@turbolent
use primitivestatictype for capcon type
f47ebd4
@turbolent
remove capabilitycontrollerstatictype encode impl, switch back to old…
6f7dac9 
… cadence definition
@turbolent
remove empty function blocks after merging #2302
8f56cc3
@turbolent
fix capcon string formatting
9cabe64
@turbolent
add changes to capcon FLIP, regenerate capcon definitions
4dbd772
@turbolent
remove references to revoke() fn
ad07305
@turbolent
handle capabilitycontroller primitive static type in other methods
a71980b
@turbolent
fix statictype_test to reflect newly appended statictype
be10557
@turbolent
address review comments
2f28be9
@turbolent
add simple checker tests for capcons. will add more once account capa…
f46e0d8 
…bilities pr is in
@turbolent
move invalidTypeMask back to the highest bit
455806f
@turbolent
swap hostfunctionvalue arguments after merging
0855da4
@turbolent
Apply suggestions from code review
9f244cc
@turbolent
update and rename capability controller
4393153
@turbolent
add generated code
0def4a5
@turbolent turbolent self-assigned this May 19, 2023
@github-actions
Copy link

github-actions bot commented May 19, 2023 •
edited

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit cd6eabd
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2167µs ± 0%158µs ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-254.8µs ± 0%51.2µs ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsCCF-2183ms ± 0%176ms ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-2628ms ± 0%607ms ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-25.92µs ± 0%3.69µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-23.45µs ± 0%2.85µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-23.91µs ± 0%3.98µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-24.15µs ± 0%4.06µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-23.00µs ± 0%3.02µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-23.64µs ± 0%3.70µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-23.73µs ± 0%3.75µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-23.67µs ± 0%3.74µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-22.94µs ± 0%2.90µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-23.74µs ± 0%3.64µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-215.4µs ± 0%15.1µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-28.68µs ± 0%8.46µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-213.6µs ± 0%13.2µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-219.3µs ± 0%19.0µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-28.80µs ± 0%8.63µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-211.4µs ± 0%11.5µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-212.2µs ± 0%11.6µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-211.0µs ± 0%10.8µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-29.22µs ± 0%8.62µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-212.8µs ± 0%12.3µs ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsCCF-2146ms ± 0%90ms ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-2242ms ± 0%159ms ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-21.98µs ± 0%2.62µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-21.38µs ± 0%2.25µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-22.05µs ± 0%2.83µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-22.15µs ± 0%2.97µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-21.42µs ± 0%2.31µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-21.78µs ± 0%2.96µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-21.89µs ± 0%1.85µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-21.95µs ± 0%1.88µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-21.42µs ± 0%1.40µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-21.95µs ± 0%1.83µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-23.90µs ± 0%3.71µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-22.15µs ± 0%2.00µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-23.66µs ± 0%3.35µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-24.86µs ± 0%4.92µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-22.12µs ± 0%2.16µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-22.91µs ± 0%2.81µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-23.40µs ± 0%3.35µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-22.64µs ± 0%2.54µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-22.24µs ± 0%2.05µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-23.33µs ± 0%3.16µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-2455ns ± 0%426ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-279.1ns ± 0%67.0ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-22.94ms ± 0%2.86ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-21.40µs ± 0%1.53µs ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-2802ns ± 0%722ns ± 0%~(p=1.000 n=1+1)
ParseArray-210.4ms ± 0%9.6ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-215.1ms ± 0%15.0ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-21.57ms ± 0%1.54ms ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-2246µs ± 0%240µs ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-2205µs ± 0%188µs ± 0%~(p=1.000 n=1+1)
ParseInfix-28.81µs ± 0%8.72µs ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-23.14ns ± 0%3.06ns ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-2177ns ± 0%185ns ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-26.61ms ± 0%6.44ms ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-24.74µs ± 0%5.04µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-2391ns ± 0%393ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-2163ns ± 0%170ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-2121ns ± 0%112ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-2117ns ± 0%118ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-249.2kB ± 0%49.2kB ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-223.3kB ± 0%23.4kB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsCCF-267.3MB ± 0%67.3MB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-2246MB ± 0%246MB ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-21.41kB ± 0%1.41kB ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-21.22kB ± 0%1.22kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-21.49kB ± 0%1.49kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-21.50kB ± 0%1.50kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-21.26kB ± 0%1.26kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-21.38kB ± 0%1.38kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-21.34kB ± 0%1.34kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-21.33kB ± 0%1.33kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-21.22kB ± 0%1.22kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-21.35kB ± 0%1.35kB ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-26.03kB ± 0%6.03kB ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-23.62kB ± 0%3.62kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-25.46kB ± 0%5.46kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-27.40kB ± 0%7.40kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-23.67kB ± 0%3.67kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-24.57kB ± 0%4.57kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-24.93kB ± 0%4.93kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-24.50kB ± 0%4.50kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-23.63kB ± 0%3.63kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-24.91kB ± 0%4.91kB ± 0%~(all equal)
EncodeBatchEventsCCF-240.3MB ± 0%40.3MB ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-234.0MB ± 0%34.0MB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-2808B ± 0%808B ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-2688B ± 0%688B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-2872B ± 0%872B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-2848B ± 0%848B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-2704B ± 0%704B ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-2848B ± 0%848B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-2816B ± 0%816B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-2800B ± 0%800B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-2688B ± 0%688B ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-2816B ± 0%816B ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-2768B ± 0%768B ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-2408B ± 0%408B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-2760B ± 0%760B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-2952B ± 0%952B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-2424B ± 0%424B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-2624B ± 0%624B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-2680B ± 0%680B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-2544B ± 0%544B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-2416B ± 0%416B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-2672B ± 0%672B ± 0%~(all equal)
ExportType/composite_type-2136B ± 0%136B ± 0%~(all equal)
ExportType/simple_type-20.00B 0.00B ~(all equal)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-2768B ± 0%848B ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-2200B ± 0%200B ± 0%~(all equal)
ParseArray-22.74MB ± 0%2.65MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-24.32MB ± 0%4.09MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-228.9kB ± 0%28.9kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-228.9kB ± 0%28.9kB ± 0%~(p=1.000 n=1+1)
ParseInfix-21.92kB ± 0%1.92kB ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeResourceDictionaryValues-22.29MB ± 0%2.29MB ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-22.70kB ± 0%2.76kB ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-296.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-20.00B 0.00B ~(all equal)
SuperTypeInference/integers-20.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2806 ± 0%806 ± 0%~(all equal)
ContractInterfaceFungibleToken-2370 ± 0%370 ± 0%~(all equal)
DecodeBatchEventsCCF-21.48M ± 0%1.48M ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-24.75M ± 0%4.75M ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-230.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-230.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-232.0 ± 0%32.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-229.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-231.0 ± 0%31.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-229.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-226.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-231.0 ± 0%31.0 ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-2129 ± 0%129 ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-272.0 ± 0%72.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-2103 ± 0%103 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-2163 ± 0%163 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-271.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-288.0 ± 0%88.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-296.0 ± 0%96.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-287.0 ± 0%87.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-272.0 ± 0%72.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-296.0 ± 0%96.0 ± 0%~(all equal)
EncodeBatchEventsCCF-2564k ± 0%564k ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-2757k ± 0%757k ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-211.0 ± 0%11.0 ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-211.0 ± 0%11.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-211.0 ± 0%11.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-211.0 ± 0%11.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-212.0 ± 0%12.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-212.0 ± 0%12.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-29.00 ± 0%9.00 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-212.0 ± 0%12.0 ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-217.0 ± 0%17.0 ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-214.0 ± 0%14.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-223.0 ± 0%23.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-210.0 ± 0%10.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-213.0 ± 0%13.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-217.0 ± 0%17.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-212.0 ± 0%12.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-211.0 ± 0%11.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-216.0 ± 0%16.0 ± 0%~(all equal)
ExportType/composite_type-23.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-20.00 0.00 ~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%14.0 ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-24.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-259.6k ± 0%59.6k ± 0%~(all equal)
ParseDeploy/byte_array-289.4k ± 0%89.4k ± 0%~(all equal)
ParseDeploy/decode_hex-263.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseInfix-248.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeResourceDictionaryValues-236.9k ± 0%36.9k ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-243.0 ± 0%44.0 ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-23.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-20.00 0.00 ~(all equal)
SuperTypeInference/integers-20.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

@codecov
Copy link

codecov bot commented May 19, 2023 •
edited

Codecov Report

Merging #2501 (1c409d5) into master (cd6eabd) will increase coverage by 1.09%.
The diff coverage is 83.16%.

@@            Coverage Diff             @@
##           master    #2501      +/-   ##
==========================================
+ Coverage   78.35%   79.45%   +1.09%     
==========================================
  Files         327      336       +9     
  Lines       73048    78827    +5779     
==========================================
+ Hits        57238    62630    +5392     
- Misses      13711    14018     +307     
- Partials     2099     2179      +80
Flag Coverage Δ
unittests 79.45% <83.16%> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/common/memorykind_string.go 40.00% <ø> (ø)
runtime/common/metering.go 92.32% <ø> (ø)
runtime/convertTypes.go 87.45% <0.00%> (ø)
runtime/interpreter/primitivestatictype_string.go 100.00% <ø> (ø)
runtime/interpreter/simplecompositevalue.go 77.08% <ø> (ø)
runtime/interpreter/statictype.go 77.44% <ø> (ø)
runtime/interpreter/value_account_contracts.go 77.46% <ø> (ø)
runtime/interpreter/value_accountkey.go 100.00% <ø> (ø)
runtime/interpreter/value_authaccount_inbox.go 73.07% <ø> (ø)
runtime/interpreter/value_authaccount_keys.go 74.19% <ø> (ø)
... and 42 more

... and 5 files with indirect coverage changes

@turbolent
Merge pull request #2495 from onflow/bastian/cap-cons-11
0985395 
Cap Con implementation PR feedback
@turbolent turbolent marked this pull request as ready for review May 19, 2023 14:39
dsainati1
dsainati1 approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@dsainati1 dsainati1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@SupunS
Copy link
Member

SupunS commented May 25, 2023

@turbolent The backward compatibility checker is reporting a diff in checking results. Seems there's a new error sema.InvalidEventParameterTypeError 🤔

@turbolent
Copy link
Member Author

@SupunS Good catch! That's odd, nothing changed in regards to that error or related to it. I'll investigate

@turbolent turbolent requested a review from dsainati1 May 25, 2023 23:38
@turbolent
Copy link
Member Author

@onflow/cadence Changed the reference-typed fields in the account types, to avoid the breaking change of account types not being able to be used in events anymore in 1c409d5 (#2501)

SupunS
SupunS approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@turbolent turbolent merged commit ed98581 into master May 26, 2023
17 of 22 checks passed
@turbolent turbolent deleted the feature/capability-controllers branch May 26, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@dsainati1 dsainati1 Awaiting requested review from dsainati1 dsainati1 is a code owner

Assignees

@turbolent turbolent

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turbolent @SupunS @dsainati1