Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Word256 integer type #2510

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

darkdrag00nv2
Copy link
Contributor

@darkdrag00nv2 darkdrag00nv2 commented May 27, 2023

Closes #2389
Work towards onflow/developer-grants#179

Description

This PR introduces the type Word256 to Cadence.

Will soon send the documentation PR along with Word128.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #2510 (06fa3ac) into master (326312c) will decrease coverage by 0.11%.
The diff coverage is 63.53%.

@@            Coverage Diff             @@
##           master    #2510      +/-   ##
==========================================
- Coverage   78.45%   78.35%   -0.11%     
==========================================
  Files         336      336              
  Lines       76561    77078     +517     
==========================================
+ Hits        60068    60395     +327     
- Misses      14262    14427     +165     
- Partials     2231     2256      +25     
Flag Coverage Δ
unittests 78.35% <63.53%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
encoding/ccf/traverse_value.go 98.30% <ø> (ø)
runtime/interpreter/hashablevalue.go 100.00% <ø> (ø)
runtime/interpreter/primitivestatictype_string.go 100.00% <ø> (ø)
runtime/interpreter/visitor.go 8.33% <0.00%> (-0.18%) ⬇️
runtime/interpreter/value.go 68.67% <54.51%> (-0.41%) ⬇️
runtime/interpreter/encode.go 67.26% <66.66%> (-0.01%) ⬇️
types.go 85.54% <66.66%> (-0.13%) ⬇️
encoding/json/decode.go 88.02% <68.75%> (-0.31%) ⬇️
runtime/interpreter/decode.go 46.88% <70.58%> (+0.26%) ⬆️
values.go 76.19% <80.00%> (+0.10%) ⬆️
... and 13 more

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent self-assigned this May 29, 2023
@turbolent turbolent merged commit a9e18c2 into onflow:master May 29, 2023
9 of 14 checks passed
@darkdrag00nv2 darkdrag00nv2 deleted the word256 branch May 30, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return overflowing value when multiplying for UInt256 and Int256
3 participants