Allow emit statements in conditions #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 759b814 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## feature/stable-cadence #2589 +/- ##
==========================================================
+ Coverage 78.99% 79.02% +0.03%
==========================================================
Files 340 340
Lines 81609 81724 +115
==========================================================
+ Hits 64467 64584 +117
Misses 14792 14792
+ Partials 2350 2348 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Ready for review, but going to add some more tests |
turbolent
commented
Jun 21, 2023
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (checker *Checker) rewritePostConditions(postConditions ast.Conditions) PostConditionsRewrite { |
There was a problem hiding this comment.
Moved from https://github.com/onflow/cadence/pull/2589/files#diff-74d0954852bf407e9259a7c9bb55e8af093f080f00f5e35689c250886c29860aL1961 and refactored into sub-functions
| return | ||
| } | ||
|
|
||
| func (checker *Checker) rewriteEmitPostCondition( |
SupunS
reviewed
Jun 21, 2023
SupunS
approved these changes
Jun 22, 2023
dsainati1
approved these changes
Jun 22, 2023
|
Added more tests in the last commits, but also fixed a parsing bug in 0638f55, where condition parse errors would not be propagated properly. @onflow/cadence Could you please have another look, especially at this fix? |
dsainati1
approved these changes
Jun 30, 2023
|
@SupunS could you please have another look? |
turbolent
force-pushed
the
bastian/emit-events-in-conditions
branch
from
a37f82d
to
379df98
Compare
|
Rebased on Stable Cadence, as the parsing fix is a breaking change |
|
Even though the FLIP says so, event emission was not considered a pure operation yet. I changed the event constructor to be always pure in 379df98. cc @dsainati1 |
SupunS
approved these changes
Jul 6, 2023
|
Curious about what was causing the parser fix to break existing code? Were there any invalid codes that were treated as correct? |
|
@SupunS yes, some contracts have invalid trailing tokens in conditions, and those were just ignored, but now the errors for them are propagated and reported properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2069
Description
Implementation of onflow/flips#111
masterbranchFiles changedin the Github PR explorer