Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #277

Merged
merged 22 commits into from Jul 30, 2020
Merged

Update documentation #277

merged 22 commits into from Jul 30, 2020

Conversation

turbolent
Copy link
Member

Closes #237

  • Document:
    • Run-time types
    • Crypto contract
    • Type hierarchy
    • New address format
    • toString function for addresses and numbers
    • Address.toBytes() and Number.toBigEndianBytes() functions
    • String.decodeHex() function
    • Storability requirement for field types
    • Implementation status for field getters and setters
    • unsafeRandom function
    • Transaction parameters
    • Account creation
  • Update the Crypto contract to use docstrings

@turbolent turbolent added the Documentation Improvements or additions to documentation label Jul 30, 2020
@turbolent turbolent self-assigned this Jul 30, 2020
joshuahannan
joshuahannan approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just had a few comments

docs/language.md Outdated Show resolved Hide resolved
docs/language.md Outdated Show resolved Hide resolved
docs/language.md Outdated Show resolved Hide resolved
docs/language.md Outdated Show resolved Hide resolved
docs/language.md Show resolved Hide resolved
@turbolent
Copy link
Member Author

@joshuahannan Thanks for the review! Addresses your feedback and questions, could you please have another look at the updated parts? Thank you!

@turbolent turbolent merged commit 1a2645e into master Jul 30, 2020
@turbolent turbolent deleted the bastian/documentation branch July 30, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

@10thfloor 10thfloor Awaiting requested review from 10thfloor

@psiemens psiemens Awaiting requested review from psiemens

@benjaminkvm benjaminkvm Awaiting requested review from benjaminkvm

Assignees

@turbolent turbolent

Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation
2 participants
@turbolent @joshuahannan