Fix the suggestion in the error when an interface is used as a type #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggestion in the error message that is reported when an interface is used as a type and not in a restricted type as expected was wrong when the interface is not at the root of the type, but inside another type.
For example, for an incorrect type
{Int: SomeInterface}, the suggestion wasAnyStruct{{Int: SomeInterface}}, but should be{Int: AnyStruct{SomeInterface}}.Fix this by recursively rewriting the type (if needed), instead of just rewriting at root of the type.
Discovered by @MaxStalker in his live-stream 馃檹