Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider existing prefix when suggesting completion items #285

Merged
merged 2 commits into from Aug 4, 2020
Merged

Consider existing prefix when suggesting completion items #285

merged 2 commits into from Aug 4, 2020

Conversation

turbolent
Copy link
Member

When suggesting declaration completion items, check if the document already contains an access modifier, and if so, only suggest the remainder.

Also, don't suggest write access modifier pub(set) for declaration completion items.

@turbolent turbolent self-assigned this Aug 3, 2020
benjaminkvm
benjaminkvm approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@benjaminkvm benjaminkvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent merged commit 818a4ea into master Aug 4, 2020
@turbolent turbolent deleted the bastian/completion-access-modifier-prefix branch August 4, 2020 23:51
@alse alse mentioned this pull request Oct 18, 2022
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminkvm benjaminkvm benjaminkvm approved these changes

@psiemens psiemens Awaiting requested review from psiemens

@joshuahannan joshuahannan Awaiting requested review from joshuahannan

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbolent @benjaminkvm