Recursively check if assignment target expression is valid, don't copy returned values #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just checking if the outer-most expression which is assigned to is assignable, recursively check if it is assignable. Assignable expressions are only identifiers, index expressions, and member access expressions.
This then allows removing the defensive copying of the return statement value. As values are still copied in variable declarations and when passed as arguments, there is no way to return an object and have the caller modify it.