Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add position information to interpreter errors #424

Merged
merged 2 commits into from Oct 29, 2020
Merged

Add position information to interpreter errors #424

merged 2 commits into from Oct 29, 2020

Conversation

turbolent
Copy link
Member

Work towards dapperlabs/flow-go#2426

Improve fatal interpreter errors by wrapping them with position information.

  • Before:

    Screen Shot 2020-10-22 at 11 39 57 AM

  • After:

    Screen Shot 2020-10-22 at 11 37 15 AM

@turbolent turbolent self-assigned this Oct 22, 2020
psiemens
psiemens approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

runtime/cmd/cmd.go Show resolved Hide resolved
@turbolent turbolent merged commit cc68bc1 into master Oct 29, 2020
@turbolent turbolent deleted the bastian/interpreter-errors branch October 29, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiemens psiemens psiemens approved these changes

@jordanschalm jordanschalm jordanschalm approved these changes

@zhangchiqing zhangchiqing Awaiting requested review from zhangchiqing

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turbolent @psiemens @jordanschalm