Optimize activations #571
Merged
Optimize activations #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
approved these changes
Feb 2, 2021
dete
reviewed
Feb 2, 2021
| name := string(entry.(common.StringEntry)) | ||
| return f(name, v) | ||
| }) | ||
| func (a *Activation) ForEach(cb func(string, interface{}) error) error { |
There was a problem hiding this comment.
This doesn't look like it iterates over the entries in the parent. This will be tricky, because I assume you don't want to iterate over any entires in a parent that are "shadowed" in a descendent. Not sure how to do this efficiently, to be honest!
There was a problem hiding this comment.
Refactored in 56e851c (#571)
dete
reviewed
Feb 2, 2021
dete
reviewed
Feb 2, 2021
| if current == nil { | ||
| return NewActivation() | ||
| return NewActivation(nil) |
There was a problem hiding this comment.
It's surprising to me that if there is no current activation, that you don't create one and make it the current. Clearly this logic hasn't changed with this PR, but maybe a comment is warranted here?
dete
reviewed
Feb 2, 2021
dete
reviewed
Feb 2, 2021
| @@ -156,22 +156,21 @@ func (a *VariableActivations) DeclareImplicitConstant( | |||
| ) | |||
| } | |||
|
|
|||
| func (a *VariableActivations) VariablesDeclaredInAndBelow(depth int) map[string]*Variable { | |||
| variables := map[string]*Variable{} | |||
| func (a *VariableActivations) ForEachVariablesDeclaredInAndBelow(depth int, f func(name string, value *Variable)) { | |||
There was a problem hiding this comment.
Oh! I like this... Iterate in place instead of building a list and iterating over the list. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the use of HAMT maps in activations with a plain map and a parent chain.
For contributor use:
masterbranchFiles changedin the Github PR explorer