Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor String, AuthAccount.Contracts, and DeployedContract type to singleton #625

Merged
merged 5 commits into from
Feb 26, 2021
Merged

Refactor String, AuthAccount.Contracts, and DeployedContract type to singleton #625

merged 5 commits into from
Feb 26, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 24, 2021 •
edited

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Feb 24, 2021
Base automatically changed from bastian/type-singletons-3 to master February 25, 2021 18:05
@turbolent
Copy link
Member Author

Rebased to fix conflicts

@SupunS SupunS merged commit d19d993 into master Feb 26, 2021
@turbolent turbolent deleted the bastian/type-singletons-4 branch February 26, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbolent @SupunS