New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize encoding of positive bigints #637

Merged

turbolent merged 1 commit into master from bastian/optimize-positive-bigint-encoding

Mar 2, 2021

Member

turbolent commented Mar 1, 2021

Description

The CBOR library's bigint encoding function always creates a copy of the encoded value: https://github.com/fxamacker/cbor/blob/ee962ff86de23bc964f19d8e4a1a23171b05e58b/encode.go#L1159.
This is not necessary for the case where the value is positive, only when it is negative.

For contributor use:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels


          optimize encoding of positive bigints

c7ff0f7

turbolent added the Improvement label

turbolent requested review from SupunS and janezpodhostnik

March 1, 2021 20:09

turbolent self-assigned this

SupunS approved these changes

View reviewed changes

turbolent merged commit 2944219 into master

turbolent deleted the bastian/optimize-positive-bigint-encoding branch

March 2, 2021 19:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment