Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize deferred dictionary keys #638

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Optimize deferred dictionary keys #638

merged 4 commits into from
Mar 2, 2021

Conversation

turbolent
Copy link
Member

Description

Only construct storage keys for deferred dictionary keys when needed, instead of creating all of them when decoding.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Mar 1, 2021
SupunS
SupunS approved these changes Mar 2, 2021
View reviewed changes
runtime/interpreter/decode.go Show resolved Hide resolved
@turbolent turbolent merged commit 302035b into master Mar 2, 2021
@turbolent turbolent deleted the bastian/optimize-deferred-dictionary-keys branch March 2, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbolent @SupunS