-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DocumentSymbol capability for Outline #662
Conversation
@MaxStalker This is awesome! What is left to be done for this PR to get merged? If you think it's ready please mark it as ready for review and I'll have a look! |
When used with transaction template it would break language server. |
@MaxStalker I spend some time this afternoon to finish this and opened a PR in #943. Do you want to sync on how we could get the PRs merged? I'd love to get this in! 🙂 |
0811969
to
8971510
Compare
Rebased and applied the commits from the follow-up PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 267 267
Lines 33001 33001
=======================================
Hits 24487 24487
Misses 7386 7386
Partials 1128 1128
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Closes #665
Description
DocumentSymbol
capability on Language Server to return items for Outline panel in VS Code (and other editors)For contributor use:
master
branchFiles changed
in the Github PR explorer