Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DocumentSymbol capability for Outline #662

Merged
merged 13 commits into from
May 25, 2021
Merged

Conversation

MaxStalker
Copy link
Contributor

@MaxStalker MaxStalker commented Mar 4, 2021

Closes #665

Description

  • enable DocumentSymbol capability on Language Server to return items for Outline panel in VS Code (and other editors)
  • add WithDocumentSymbol method to assign provider to server
  • create DocumentSymbol provider to collect DocumentSymbols
  • create convertors for AST kind to DocumentSymbol kind

Screen Shot 2021-05-24 at 6 29 41 PM


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent
Copy link
Member

@MaxStalker This is awesome! What is left to be done for this PR to get merged?

If you think it's ready please mark it as ready for review and I'll have a look!

@MaxStalker
Copy link
Contributor Author

@MaxStalker This is awesome! What is left to be done for this PR to get merged?

If you think it's ready please mark it as ready for review and I'll have a look!

When used with transaction template it would break language server.
I had no chance to look into it yet - that's why this PR is stalled.

@turbolent
Copy link
Member

@MaxStalker I spend some time this afternoon to finish this and opened a PR in #943. Do you want to sync on how we could get the PRs merged? I'd love to get this in! 🙂

@turbolent turbolent marked this pull request as ready for review May 25, 2021 17:20
@turbolent
Copy link
Member

Rebased and applied the commits from the follow-up PR

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@codecov-commenter
Copy link

Codecov Report

Merging #662 (8971510) into master (159015d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   74.20%   74.20%           
=======================================
  Files         267      267           
  Lines       33001    33001           
=======================================
  Hits        24487    24487           
  Misses       7386     7386           
  Partials     1128     1128           
Flag Coverage Δ
unittests 74.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159015d...8971510. Read the comment docs.

@turbolent turbolent merged commit baa2219 into master May 25, 2021
@turbolent turbolent deleted the max/ls-enable-outline branch May 25, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DocumentSymbol capability to Language Server
3 participants