Remove obsolete code in decode.go #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
approved these changes
Apr 12, 2021
| if err != nil { | ||
| return CapabilityValue{}, fmt.Errorf("invalid capability borrow type encoding: %w", err) | ||
| } | ||
|
|
||
| borrowType, ok = decodedStaticType.(StaticType) |
There was a problem hiding this comment.
Wondering why this was here, decodeStaticTypealready returns aStaticTypeeven onmaster. I guess it used to return interface{}`. Nice cleanup 👍
Comment on lines
-617
to
-628
| // The encoding of negative bignums is specified in | ||
| // https://tools.ietf.org/html/rfc7049#section-2.4.2: | ||
| // "For tag value 3, the value of the bignum is -1 - n." | ||
| // | ||
| // Negative bignums were encoded incorrectly in version < 2, | ||
| // as just -n. | ||
| // | ||
| // Fix this by adjusting by one. | ||
|
|
||
| if bigInt.Sign() < 0 && d.version < 2 { | ||
| bigInt.Add(&bigInt, bigOne) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #786
Description
Remove type assertions that immediately follow a function that returns the desired type.
Remove v1 compatibility code in v4
decodeBig.Caveats
The modest speedup for decoding a 167 byte LinkValue was better than expected. Final performance comparisons for this week will be added to the text of #738 (identifying the master branch commit and hash of each Value data benchmarked).
For contributor use:
feature/storage-optimizationsbranchFiles changedin the Github PR explorer