Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all occurrences of a symbol in the document #909

Merged
merged 2 commits into from
May 26, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented May 16, 2021

Description

Screen.Recording.2021-05-16.at.10.33.46.AM.mp4

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this May 16, 2021
Base automatically changed from bastian/document-highlight to master May 25, 2021 16:49
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔥

@codecov-commenter
Copy link

Codecov Report

Merging #909 (b79a584) into master (8132e81) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head b79a584 differs from pull request most recent head 11b62b2. Consider uploading reports for the commit 11b62b2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   74.05%   74.19%   +0.13%     
==========================================
  Files         269      267       -2     
  Lines       33074    32994      -80     
==========================================
- Hits        24494    24480      -14     
+ Misses       7452     7386      -66     
  Partials     1128     1128              
Flag Coverage Δ
unittests 74.19% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/common/address.go 88.88% <0.00%> (-3.12%) ⬇️
runtime/runtime.go 87.19% <0.00%> (-0.04%) ⬇️
runtime/interpreter/interpreter.go 90.11% <0.00%> (-0.03%) ⬇️
runtime/ast/import.go 73.33% <0.00%> (ø)
runtime/ast/visitor.go 33.33% <0.00%> (ø)
runtime/ast/inspect.go
runtime/ast/walk.go
fixedpoint/parse.go 93.50% <0.00%> (+0.08%) ⬆️
runtime/ast/composite.go 57.44% <0.00%> (+1.19%) ⬆️
runtime/ast/program.go 73.21% <0.00%> (+1.28%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8132e81...11b62b2. Read the comment docs.

@turbolent turbolent merged commit d3e3a95 into master May 26, 2021
@turbolent turbolent deleted the bastian/renaming branch May 26, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants