Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide signature help #911

Merged
merged 2 commits into from
May 28, 2021
Merged

Provide signature help #911

merged 2 commits into from
May 28, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented May 17, 2021 •
edited

Description

Screen.Recording.2021-05-16.at.8.41.58.PM.mp4
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this May 17, 2021
@turbolent turbolent mentioned this pull request May 19, 2021
Merged
6 tasks
@turbolent turbolent force-pushed the bastian/function-invocations branch from 050b051 to 15cceee Compare May 26, 2021 18:38
Base automatically changed from bastian/function-invocations to master May 27, 2021 16:15
SupunS
SupunS approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Very useful feature! 👌

@turbolent turbolent merged commit 580cd49 into master May 28, 2021
@turbolent turbolent deleted the bastian/signature-help branch May 28, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@MaxStalker MaxStalker Awaiting requested review from MaxStalker

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbolent @SupunS