Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HexToAddress utility function, add tests for address functions #932

Merged
merged 1 commit into from
May 25, 2021
Merged

Add HexToAddress utility function, add tests for address functions #932

merged 1 commit into from
May 25, 2021

Conversation

turbolent
Copy link
Member

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this May 21, 2021
SupunS
SupunS approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@turbolent turbolent merged commit 159015d into master May 25, 2021
@turbolent turbolent deleted the bastian/test-addresses branch May 25, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Feature Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbolent @SupunS