Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only wrap a type in an optional if it is not nil #937

Merged
merged 4 commits into from
May 24, 2021

Conversation

turbolent
Copy link
Member

Fix by @SupunS 馃憦

Same as #936, against master


  • Targeted PR against master
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from SupunS May 23, 2021 18:17
@turbolent turbolent self-assigned this May 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #937 (9505d86) into master (2d95036) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   74.19%   74.19%           
=======================================
  Files         267      267           
  Lines       32993    32994    +1     
=======================================
+ Hits        24479    24480    +1     
  Misses       7386     7386           
  Partials     1128     1128           
Flag Coverage 螖
unittests 74.19% <100.00%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
runtime/sema/check_force_expression.go 90.90% <100.00%> (-0.76%) 猬囷笍
runtime/sema/check_invocation_expression.go 98.69% <100.00%> (酶)
runtime/sema/check_reference_expression.go 100.00% <100.00%> (酶)
runtime/sema/checker.go 89.94% <100.00%> (+0.03%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2d95036...9505d86. Read the comment docs.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@turbolent turbolent merged commit 33432e8 into master May 24, 2021
@turbolent turbolent deleted the bastian/fix-optional-reference-checking branch May 24, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants