Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code action to implement missing members #942

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented May 24, 2021

Work towards onflow/cadence-tools#100 and onflow/vscode-cadence#41

Description

Provide a code action / quick fix to implement the missing members to conform to the interface:

Screen.Recording.2021-05-24.at.2.08.51.PM.mp4

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 😍

@turbolent turbolent force-pushed the bastian/code-actions branch 3 times, most recently from 5810b28 to 5703794 Compare June 1, 2021 17:16
Base automatically changed from bastian/code-actions to master June 1, 2021 17:16
@turbolent turbolent force-pushed the bastian/add-missing-members-code-action branch from 01e6d81 to 9d52ba9 Compare June 1, 2021 17:18
@turbolent turbolent merged commit d666b32 into master Jun 1, 2021
@turbolent turbolent deleted the bastian/add-missing-members-code-action branch June 1, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants