Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coverage of empty functions from report #944

Merged
merged 1 commit into from
May 26, 2021

Conversation

turbolent
Copy link
Member

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this May 26, 2021
@turbolent turbolent force-pushed the bastian/empty-function-coverage branch from f06d14d to e380188 Compare May 26, 2021 01:12
@codecov-commenter
Copy link

Codecov Report

Merging #944 (e380188) into master (a0332c6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #944   +/-   ##
=======================================
  Coverage   74.05%   74.05%           
=======================================
  Files         269      269           
  Lines       33074    33074           
=======================================
+ Hits        24492    24494    +2     
+ Misses       7453     7452    -1     
+ Partials     1129     1128    -1     
Flag Coverage Δ
unittests 74.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/runtime_storage.go 87.87% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0332c6...e380188. Read the comment docs.

@turbolent
Copy link
Member Author

Looks like Codecov did this already, I'll merge anyways

@turbolent turbolent merged commit 82674ed into master May 26, 2021
@turbolent turbolent deleted the bastian/empty-function-coverage branch May 26, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants