Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide code action to declare field and function #961

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Provide code action to declare field and function #961

merged 7 commits into from
Jun 1, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented May 30, 2021 •
edited

Description

Screen.Recording.2021-05-30.at.2.08.05.PM.mp4
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this May 30, 2021
janezpodhostnik
janezpodhostnik approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of experience with this, but the code makes sense to me.

@turbolent turbolent force-pushed the bastian/declare-variable-action branch from 0126fbd to 6c49c7c Compare June 1, 2021 17:30
Base automatically changed from bastian/declare-variable-action to master June 1, 2021 17:30
@turbolent turbolent force-pushed the bastian/declare-function-action branch from c051657 to 6408827 Compare June 1, 2021 17:36
@turbolent turbolent merged commit 895d6b0 into master Jun 1, 2021
@turbolent turbolent deleted the bastian/declare-function-action branch June 1, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@MaxStalker MaxStalker Awaiting requested review from MaxStalker

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

Assignees

@turbolent turbolent

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbolent @janezpodhostnik