Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions/setup-go@v2 to speed up CI by ~10 secs and specify Go 1.15.x #971

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

fxamacker
Copy link
Member

Closes #970

Description

actions/setup-go@v1 has a performance bug which can cost an extra ~10 secs to install Go.

actions/setup-go@v2 fixes the performance bug and supports ".x" in the version string.

With v2, specifying "1.15.x" will install the latest 1.15 available.

  • Use actions/setup-go@v2.
  • Specify go-version: '1.15.x'.

See actions/setup-go#39


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

actions/setup-go@v1 has a performance bug
which can cost an extra ~10 secs to install Go.

actions/setup-go@v2 support ".x" in the version
so "1.15.x" will install the latest 1.15 available.

 - Use actions/setup-go@v2.
 - Specify go-version: '1.15.x'.
@fxamacker fxamacker added the Chore label Jun 3, 2021
@fxamacker fxamacker changed the title Use actions/setup-go@v2 to speed up CI by ~10 secs and specify go 1.15.x Use actions/setup-go@v2 to speed up CI by ~10 secs and specify Go 1.15.x Jun 3, 2021
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

@fxamacker fxamacker merged commit 3386e0f into master Jun 3, 2021
@fxamacker fxamacker deleted the fxamacker/optimize-github-actions branch June 3, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use actions/setup-go@v2 to speed up CI by ~10 secs and specify Go 1.15.x
2 participants