Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and extend the source compatibility suite #977

Merged
merged 7 commits into from
Jun 4, 2021

Conversation

turbolent
Copy link
Member

Work towards #974

Description

  • Fix the FT suite
  • Add support for running the Go tests of a suite using the latest Cadence version
  • Fix the command line check program: Also check the imported programs
  • Add the NBA Top Shot contracts as a suite

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #977 (7801909) into master (3386e0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #977   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files         268      268           
  Lines       32870    32870           
=======================================
  Hits        24805    24805           
  Misses       6929     6929           
  Partials     1136     1136           
Flag Coverage Δ
unittests 75.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3386e0f...7801909. Read the comment docs.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. I don't have much of an idea of what this module/code does though.

@turbolent
Copy link
Member Author

@SupunS There a short description here https://github.com/onflow/cadence/tree/master/compat#source-compatibility-suite. It's similar to / inspired by Swift's Source Compatibility Suite. Let me know if you want to talk more about it!

It would be great to extend it further and use it more to influence our decisions when working on Cadence and also improve our confidence when releasing new versions

@turbolent turbolent merged commit 4367803 into master Jun 4, 2021
@turbolent turbolent deleted the bastian/974-update-source-compat-suite branch June 4, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants