-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto update flow-go github action #981
Conversation
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 268 268
Lines 32870 32870
=======================================
Hits 24805 24805
Misses 6929 6929
Partials 1136 1136
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looking forward to using this 👍
pull_request: | ||
branches: | ||
- master | ||
types: [closed] | ||
|
||
jobs: | ||
sync-flow-go: | ||
runs-on: ubuntu-latest | ||
# the PR could have been closed otherwise. Only run if it has actually ben merged | ||
if: github.event.pull_request.merged == true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be simplified to just run on each push to master?
But then I guess the events at the bottom (github.event.pull_request
) aren't available / would need to change?
pull_request: | |
branches: | |
- master | |
types: [closed] | |
jobs: | |
sync-flow-go: | |
runs-on: ubuntu-latest | |
# the PR could have been closed otherwise. Only run if it has actually ben merged | |
if: github.event.pull_request.merged == true | |
push: | |
branches: | |
- master | |
jobs: | |
sync-flow-go: | |
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convenience of having a reference of a Cadence PR in the generated flow-go PR would be lost... Not sure that would be the best approach.
Are there pushes to master that happen without PRs?
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
@turbolent when you have some time, could you add the |
Added the secret, should be good to go now! |
Closes https://github.com/dapperlabs/flow-internal/issues/1517
Description
A github action that creates a PR in flow-go to update cadence version every time a PR is merged into master in cadence. The PRs in flow-go are based on the master branch or the latest
auto-cadence-upgrade/*
branch if it existsI tested this on private repos, but it might still need some tweaking on the
go get && make tidy
part.master
branchFiles changed
in the Github PR explorer