Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check 'importability' instead of 'storability' for transaction arguments #983

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Check 'importability' instead of 'storability' for transaction arguments #983

merged 1 commit into from
Jun 8, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 7, 2021 •
edited

Work towards #979
Work towards #717

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS requested a review from turbolent as a code owner June 7, 2021 10:28
@SupunS SupunS self-assigned this Jun 7, 2021
turbolent
turbolent approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@turbolent
Copy link
Member

Great job at splitting this work up into multiple PRs 👍

Base automatically changed from supun/importable to master June 8, 2021 03:58
@SupunS SupunS merged commit a9fa787 into master Jun 8, 2021
@SupunS SupunS deleted the supun/tx-arg-validation branch June 8, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@SupunS SupunS

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SupunS @turbolent