Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebrand Previewnet #87

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Rebrand Previewnet #87

merged 3 commits into from
Feb 26, 2024

Conversation

chasefleming
Copy link
Member

Closes #???

Description

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flow-faucet-crescendo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 7:40pm
flow-faucet-testnet ❌ Failed (Inspect) Feb 26, 2024 7:40pm

@chasefleming chasefleming changed the title Cf/rebrand previewnet Rebrand Previewnet Feb 26, 2024
gregsantos
gregsantos reviewed Feb 26, 2024
View reviewed changes
lib/constants.ts
@@ -1,8 +1,8 @@
export type Networks = "testnet" | "crescendo"
export type Networks = "testnet" | "previewnet"
export type TokenTypes = typeof FLOW_TYPE | typeof FUSD_TYPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 FUSD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't show anywhere else. It's removed on master.

lib/publicConfig.ts
@@ -6,8 +6,8 @@ if (!network) throw "Missing NEXT_PUBLIC_NETWORK"
const testNetUrl = process.env.NEXT_PUBLIC_TEST_NET_URL
if (!testNetUrl) throw "Missing NEXT_PUBLIC_TEST_NET_URL"

const crescendoNetUrl = process.env.NEXT_PUBLIC_CRESCENDO_URL
if (!crescendoNetUrl) throw "Missing NEXT_PUBLIC_CRESCENDO_URL"
const previewnetUrl = process.env.NEXT_PUBLIC_PREVIEWNET_URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using PREVIEW_NET elsewhere

env.example
@@ -1,6 +1,6 @@
NEXT_PUBLIC_NETWORK=testnet
NEXT_PUBLIC_TEST_NET_URL=http://localhost:3000
NEXT_PUBLIC_CRESCENDO_URL=http://localhost:3000
NEXT_PUBLIC_PREVIEWNET_URL=http://localhost:3000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using PREVIEW_NET elsewhere

@chasefleming chasefleming merged commit 73c28a3 into evm-enabled Feb 26, 2024
4 of 5 checks passed
@chasefleming chasefleming deleted the cf/rebrand-previewnet branch February 26, 2024 19:47
chasefleming added a commit that referenced this pull request Feb 27, 2024
@chasefleming
Merge pull request #87 from onflow/cf/rebrand-previewnet
0c6624f 
Rebrand Previewnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsantos gregsantos gregsantos left review comments

@jribbink jribbink Awaiting requested review from jribbink jribbink is a code owner

@ianthpun ianthpun Awaiting requested review from ianthpun ianthpun is a code owner

@bthaile bthaile Awaiting requested review from bthaile bthaile is a code owner

@sisyphusSmiling sisyphusSmiling Awaiting requested review from sisyphusSmiling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chasefleming @gregsantos