Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use local service config when network is emulator #173

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

bthaile
Copy link
Contributor

@bthaile bthaile commented Jan 5, 2024

closes: #172

Update to support emulator as a network, use local service config. This gives the user dev wallet to interact with the emulator.

@bthaile bthaile requested a review from a team as a code owner January 5, 2024 23:50
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fcl-discovery ✅ Ready (Inspect) Visit Preview Jan 5, 2024 11:50pm

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we need to define an endpoint for "emulator" since "local" exists & this is the de facto standard naming for the local network in FCL. What is the use case here? Are we trying to change the endpoint that users use for the local network in discovery?

@bthaile
Copy link
Contributor Author

bthaile commented Jan 8, 2024

A few thoughts,
there is no network "local" there is "emulator", dedicated by flow-cli --netowrk emulator this PR is an effort standardize network names. Also FLIX gets it's network names from flow-cli terminology and creates network sections for emulator, testnet and mainnet.

A few thoughts,
there is no network "local" there is emulator, dedicated by flow-cli --netowrk emulator this PR is an effort standardize network names. Also FLIX gets it's network names from flow-cli terminology and creates network sections for emulator, testnet and mainnet.

@bthaile bthaile merged commit d8f27fc into master Jan 8, 2024
3 checks passed
@bthaile bthaile deleted the support-emulator-network branch January 8, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] emulator as a network not supported
4 participants