Update services.json
#184
Draft
Update services.json
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #183
This introduces
ServiceProviderv1.1.0, which now includes an optional field forwalletConnectId. This is helps FCL clients draw an association between wallet providers and their WalletConnect registrations & enables associated UX improvements - it is up to the client if they want to use this information. (will probably need a small FLIP/update to FCL spec).Additionally, I've sifted through the
services.jsonand cleaned up the services a bit (adding necessary version numbers, and data types). It's important we start getting in the habit of including these, even thoughv1.0.0is implicit.