Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] signUserMessage type is incorrect #1642

Closed
bthaile opened this issue May 10, 2023 · 2 comments
Closed

[BUG] signUserMessage type is incorrect #1642

bthaile opened this issue May 10, 2023 · 2 comments
Assignees
Labels
Bug Something isn't working

Comments

@bthaile
Copy link
Contributor

bthaile commented May 10, 2023

Current Behavior

using these versions
"@onflow/fcl": "^1.4.0-alpha.8",
"@onflow/typedefs": "^1.1.0-alpha.4",

const sign = await fcl.currentUser.signUserMessage(MSG);
// types think that signUserMessage returns a CompositeSignature` and is not an array

// but in reality it is an array
const [{ signature }] = sign;

Screenshot 2023-05-10 at 11 46 16 AM

Expected Behavior

expected types to match up with reality

Steps To Reproduce

sign a message

Environment

- OS: mac
- Node: v19
- npm: 9.5

What are you currently working on that this is blocking?

No response

@JeffreyDoyle
Copy link
Member

Hey @nialexsan , is this issue complete?

@nialexsan
Copy link
Contributor

@JeffreyDoyle yes, we've merged the fix already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants