You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, signing algorithm IDs do not match those known to the cadence runtime (SignatureAlgorithm enum from Crypto stdlib). This is not a "bug" per se, as is actually by design to match flow-go. However, it can be very misleading for developers looking to upgrade to Cadence 1.0
These would ideally match because of users attempting to upgrade their code to Cadence 1.0 & mistakenly assuming these constants match 1:1 with those in the Cadence runtime. Because of the requirement to upgrade to the new Key Management API, many users will likely attempt to convert their code in a way that leverages the key ID constants exported by this library.
However, this would be difficult to change due to backward compability risks & would probably require a major version change.
There has been discussion in onflow/flow-go#3318 surrounding this issue, and these specific key IDs known to @onflow/util-encode-key historically existed because key-encoding was apart of flow-go, so the @onflow/util-encode-key utility had to match. However, it may be time to deprecate this library because this Key Management API is as well being deprecated and simply include these constants as apart of FCL-JS, if necessary.
The text was updated successfully, but these errors were encountered:
jribbink
changed the title
[BUG] Signing algorithm IDs do not match those known to Cadence
[BUG] Signing algorithm IDs do not match those in Cadence
Feb 27, 2024
Currently, signing algorithm IDs do not match those known to the cadence runtime (
SignatureAlgorithm
enum from Crypto stdlib). This is not a "bug" per se, as is actually by design to match flow-go. However, it can be very misleading for developers looking to upgrade to Cadence 1.0These would ideally match because of users attempting to upgrade their code to Cadence 1.0 & mistakenly assuming these constants match 1:1 with those in the Cadence runtime. Because of the requirement to upgrade to the new Key Management API, many users will likely attempt to convert their code in a way that leverages the key ID constants exported by this library.
However, this would be difficult to change due to backward compability risks & would probably require a major version change.
There has been discussion in onflow/flow-go#3318 surrounding this issue, and these specific key IDs known to @onflow/util-encode-key historically existed because key-encoding was apart of flow-go, so the @onflow/util-encode-key utility had to match. However, it may be time to deprecate this library because this Key Management API is as well being deprecated and simply include these constants as apart of FCL-JS, if necessary.
The text was updated successfully, but these errors were encountered: