Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [root] Fix type declaration generation #1814

Merged
merged 11 commits into from
Nov 28, 2023
Merged

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Nov 26, 2023

closes #1817

Copy link

changeset-bot bot commented Nov 26, 2023

🦋 Changeset detected

Latest commit: f555075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@onflow/util-encode-key Patch
@onflow/transport-http Patch
@onflow/util-invariant Patch
@onflow/util-template Patch
@onflow/util-address Patch
@onflow/util-logger Patch
@onflow/fcl-bundle Patch
@onflow/util-actor Patch
@onflow/typedefs Patch
@onflow/util-uid Patch
@onflow/config Patch
@onflow/fcl-wc Patch
@onflow/types Patch
@onflow/fcl Patch
@onflow/rlp Patch
@onflow/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink marked this pull request as ready for review November 28, 2023 06:53
@jribbink jribbink requested a review from a team as a code owner November 28, 2023 06:53
@@ -1,8 +0,0 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just removed the tsconfig-web & tsconfig-react-native configs. I don't think types were working properly for react native anyways & we are going to split into separate packages so this is unnecessary

@jribbink jribbink merged commit 0d09d83 into master Nov 28, 2023
1 check passed
@jribbink jribbink deleted the jribbink/types-build-fix branch November 28, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Issues with type declarations
2 participants