This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Upgrade to badger V3 #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koko1123
assigned SaveTheRbtz, diaswrd, zhangchiqing and koko1123 and unassigned SaveTheRbtz, diaswrd and zhangchiqing
koko1123
requested review from
diaswrd,
lolpuddle,
SaveTheRbtz and
zhangchiqing
diaswrd
approved these changes
Jan 18, 2023
| @@ -21,7 +21,7 @@ import ( | |||
|
|
|||
| "golang.org/x/sync/errgroup" | |||
|
|
|||
| "github.com/dgraph-io/badger/v2" | |||
| "github.com/dgraph-io/badger/v3" | |||
SaveTheRbtz
approved these changes
Jan 20, 2023
SaveTheRbtz
reviewed
Jan 24, 2023
| "badger_v2_lsm_level_gets_total": prometheus.NewDesc("archive_badger_lsm_level_gets_total", "number of LSM gets", []string{"level"}, nil), | ||
| "badger_v2_lsm_size_bytes": prometheus.NewDesc("archive_badger_lsm_size_bytes", "size of the LSM in bytes", []string{"path"}, nil), | ||
| "badger_v2_vlog_size_bytes": prometheus.NewDesc("archive_badger_vlog_size_bytes", "size of the value log in bytes", []string{"path"}, nil), | ||
| "badger_v4_disk_reads_total": prometheus.NewDesc("archive_badger_disk_reads_total", "cumulative number of reads", nil, nil), |
|
Before committing to master you may want to try deploying the package from this branch to verify that this fixes resource consumption issue |
SaveTheRbtz
reviewed
Jan 24, 2023
Comment on lines
-25
to
-37
| WithMaxTableSize(256 << 20). | ||
| WithValueLogFileSize(64 << 20). | ||
| WithTableLoadingMode(options.FileIO). | ||
| WithValueLogLoadingMode(options.FileIO). | ||
| WithNumMemtables(1). | ||
| WithKeepL0InMemory(false). | ||
| WithCompactL0OnClose(false). | ||
| WithNumLevelZeroTables(1). | ||
| WithNumLevelZeroTablesStall(2). | ||
| WithLoadBloomsOnOpen(false). | ||
| WithIndexCacheSize(2000 << 20). | ||
| WithBlockCacheSize(0). | ||
| WithLogger(nil) |
There was a problem hiding this comment.
do you still need these changes or were they related to things cut in v4?
|
parallel effort from @SaveTheRbtz closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Switch badger to V3 from https://github.com/outcaste-io/badger/tags