Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple imports from a single address in flow-cadut #119

Merged
merged 8 commits into from
Aug 26, 2022

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Aug 11, 2022

Closes #117

Description

  • Allows for multiple imports in flow-cadut (updates replaceImportAddresses)
  • Adds relevant unit tests
  • Moves misplaced test from monorepo transition & updates docs

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

⚠️ No Changeset found

Latest commit: aad9ca9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink changed the title Allow for m Allow for multiple imports from a single address in flow-cadut Aug 11, 2022
@jribbink
Copy link
Contributor Author

CI Tests are failing due to #120

@jribbink jribbink marked this pull request as ready for review August 11, 2022 20:13
@jribbink jribbink requested review from a team and MaxStalker as code owners August 11, 2022 20:13
…mports & replaceImportAddresses to use same code
@jribbink jribbink merged commit 49c3d81 into master Aug 26, 2022
@jribbink jribbink deleted the jribbink/multiple-imports branch August 26, 2022 16:52
jribbink added a commit that referenced this pull request Aug 26, 2022
@jribbink jribbink restored the jribbink/multiple-imports branch August 26, 2022 16:55
@jribbink jribbink deleted the jribbink/multiple-imports branch August 26, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replaceImportAddresses does not work with multiple imports
3 participants