Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network check for staging functionality #1500

Merged
merged 2 commits into from Apr 9, 2024
Merged

Add network check for staging functionality #1500

merged 2 commits into from Apr 9, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 9, 2024

Disallow staging outside of testnet/mainnet

chasefleming
chasefleming approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just make that into reusable function?

@jribbink jribbink merged commit 8b02050 into feature/stable-cadence Apr 9, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/no-staging-local branch April 9, 2024 18:38
@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

@nvdtf nvdtf nvdtf approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@sideninja sideninja Awaiting requested review from sideninja sideninja is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner

@ianthpun ianthpun Awaiting requested review from ianthpun ianthpun is a code owner

Assignees
No one assigned
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jribbink @chasefleming @nvdtf