Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FlowToken Deposit and Withdraw events #434

Open
joshuahannan opened this issue Jun 6, 2024 · 0 comments
Open

Remove FlowToken Deposit and Withdraw events #434

joshuahannan opened this issue Jun 6, 2024 · 0 comments
Assignees
@joshuahannan
Labels
Breaking Change enhancement New feature or request Improvement Performance

Comments

@joshuahannan
Copy link
Member

Issue To Be Solved

The FlowToken.TokensDeposited and FlowToken.TokensWithdrawn events take up unnecessary computation and space in transaction results now that the FungibleToken standard events exist. They should be removed

Suggest A Solution

  • Work with all partners who rely on FlowToken events and tell them that they need to migrate their integrations to the FungibleToken events.
  • Remove the event emissions and events from the contract
  • Create an upgrade plan and post to the forum and discord well in advance
  • Upgrade the contract on testnet and mainnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuahannan joshuahannan

Labels
Breaking Change enhancement New feature or request Improvement Performance
Projects
🌊 Flow 4D
Status: 🔖 Ready for Pickup
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuahannan