FEATURE: Cadence 1.0 Core Contracts Changes #319
+12,441
−25,025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
joshuahannan
force-pushed
the
stable-cadence
branch
from
7479ccf
to
18e5b36
Compare
bluesign
reviewed
Jul 7, 2023
bluesign
reviewed
Jul 7, 2023
* update to view functions for stable cadence * remove unreachable code * update templates to Stable Cadence * update to Stable Cadence preview 4 * update for stable cadence * fix parse error --------- Co-authored-by: Josh Hannan <hannanjoshua19@gmail.com> Co-authored-by: Bastian Müller <bastian@axiomzen.co>
joshuahannan
force-pushed
the
stable-cadence
branch
from
0e0a35d
to
253f985
Compare
* Don't copy dictionary in getEpochMetadata
* update deps, add entitlement for locked account creator * make ci
dryruner
reviewed
May 2, 2024
joshuahannan
requested review from
jordanschalm,
janezpodhostnik and
sisyphusSmiling
and removed request for
bluesign
|
I think we're basically ready to merge this to master, so I added a few people who might be able to give it a review! The changes are fairly straightforward, just lots of boilerplate updates to be compatible with the new token standards and Cadence 1.0. Let me know if you'd like to chat with me first about the changes before you review. |
janezpodhostnik
approved these changes
May 8, 2024
|
@sisyphusSmiling The changes were big enough that I just created a PR with them for you to review. Can you take a look? |
* better use of revertible random with correct types * improve random distribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes related to Cadence 1.0
Many functions have been changed to
viewfor new view function requirementsUpdates casting to use correct
assyntaxchanges
pubtoaccess(all)Adds entitlements
Uses the new fungible token standard and
BurnercontractRemoves custom destructors