New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulator Feature: Report gas used #87

Merged

sideninja merged 7 commits into onflow:master from avcdsld:flip-fest-issue-12-report-gas-used

Sep 29, 2021

Contributor

avcdsld commented Sep 26, 2021 •

edited

Closes: FLIP Fest issue 12 onflow/flip-fest#12

Description

There should be a way to see transaction gas (computation) usage.

With this change, the output result of the transaction execution will look like this

BEFORE

AFTER

Other

Since there was no specific test code for the standard output of "txID=xxxxxx" that is currently displayed, I decided that there was no need to add any specific test code for this change as well.

I checked to see if any changes were needed in this document, but it looks like no changes are needed.
https://docs.onflow.org/flow-cli/start-emulator/

For contributor use:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels


          add gasUsed report feature

1dcca47

avcdsld requested review from janezpodhostnik, psiemens, sideninja and turbolent as code owners

September 26, 2021 15:09

avcdsld mentioned this pull request

Emulator Feature: Report gas used onflow/flip-fest#12

Open

Member

sideninja commented Sep 28, 2021

Thank you for adding this, it looks good, however, it does highlight the lack of tests for convert/vm.go and types/result.go so if you could please add those it would be great.

sideninja requested changes

View reviewed changes

Member

sideninja left a comment

Missing tests needs to be implemented

avcdsld added 2 commits

September 28, 2021 21:51


          add vm_test

90fdfee


          add types_test

0d90e5a

Contributor Author

avcdsld commented Sep 28, 2021

Thanks for checking the code.
I've added tests for convert/vm.go and types/result.go. I hope you can check it.

sideninja reviewed

View reviewed changes

types/result_test.go Show resolved Hide resolved

sideninja approved these changes

View reviewed changes

Member

sideninja left a comment

LGTM 🚀


          add test assertions

c56b9ee

janezpodhostnik reviewed

View reviewed changes

Contributor

janezpodhostnik left a comment

Looks great, just added some minor comments about naming.

convert/vm.go Outdated Show resolved Hide resolved

convert/vm_test.go Outdated Show resolved Hide resolved

server/backend/backend.go Outdated Show resolved Hide resolved

server/backend/backend.go Outdated Show resolved Hide resolved

avcdsld and others added 2 commits

September 29, 2021 08:59


          Apply suggestions from code review

Co-authored-by: Janez Podhostnik <67895329+janezpodhostnik@users.noreply.github.com>


          fix variable name

f113716

Contributor Author

avcdsld commented Sep 29, 2021

Looks great, just added some minor comments about naming.

I see, I also think that if it is more appropriate to use that term than Gas, it should be modified.
Thanks for the confirmation and the suggestion!


          fix indent

2b9498a

sideninja merged commit f62624a into onflow:master

avcdsld mentioned this pull request

Emulator Feature: Report gas used - Milestone 1 onflow/flip-fest#50

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment