-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with Switchboard #102
Comments
Hi @bjartek! Thanks for rising your concerns about this. There wasn't a FLIP for this, but a rather a design proposal, as well as a PR where this feature got discussed. (This happened before summer so you may not remember it). I'll take a look at your examples and come back to you. |
I'm not following you with the I'm very interested in discussing how can we improve the events emitted by this contract, I'll take a calm look at that latter! |
Right now if I create a wrapper around an FlowToken.Vault I cannot register that said wrapper should be called when FlowToken.Vault is sent to switchboard. The dictionary stores things on implementation type not supported type or underlying type. So the issue is not with sending funds, it is how to register when something can receive some funds. |
Could you post a little gist example of what you are trying to explain? You could only add |
I think this should be a one tool of many for This is a utility contract in my understanding. Maybe we can communicate that more clear as not standard, but a utility contract ? Like Offers or StoreFront ( though StoreFront seems a bit debatable )
Isn't this should replace TokenForwarding ? |
I forked and created a small overflow script here to show my point, I only use standard flow/dapper contracts. The ExampleToken and the TokenForwader. clone: run As you can see the last transaction fails because when i try to deposit ExampleToken to What can be done to fix it? Allow sending in the type/types your capability accepts as input. |
Was there a FLIP for the swithcboard? I have not seen one, but then I have been very busy lately.
I have somes issues with the way this is made. This is based on what we have at .find in our Profile and some experience from developing on this chain for a while.
What if i want to have something like https://github.com/bjartek/flow-sharded-wallet that can accept FlowToken.Vault and proxy that to several other users. At the moment i cannot register this with switchboard since the type of it is not FlowToken.Vault but something else.
What about the ability for a entry to say what types it supports so that you can proxy it? Kind of like we do here https://github.com/findonflow/find/blob/main/contracts/Profile.cdc#L28
This switchboard is not compatible with TokenForwarding on dapper wallet either since the type of the receiver vault is not FlowToken.Vault but TokenForwarding.
I would really like to se better events here could we create a struct like
FlowTokenAuthProvider
that has a provider cap and an amount, and then the option to only withdraw that amount of funds from the provider? That way you will have both sender and receiver and we can emit a good event with both from and to, i would also love to see an aditional context parameter here to send in related tags.The text was updated successfully, but these errors were encountered: