Implementation-of-flip-69 #123
Conversation
There was a problem hiding this comment.
I looked at the cadence code. Looks good! Can you also add implementations for the switchboard and token forwarders, and can you add a transfer transaction that accepts an address and public path as a parameter, gets the receiver reference from that path, then only deposits the tokens if the receiver.getSupportedVaultTypes() supports the type of the vault that the transaction is attempting to transfer? If it doesn't just deposit the vault back into the owner's vault
| /// | ||
| /// @return list of supported deposit vault types by the implementing resource. | ||
| /// | ||
| pub fun getSupportedVaultTypes(): [Type] { |
There was a problem hiding this comment.
Thinking about this more, I would like the return type of this to be {Type: Bool}. You can still iterate through it with return.keys, and it makes checking a specific type much easier. Do you think you'll be able to make that change in time for the upgrade next week?
|
@satyamakgec You'll need to pull the latest from master before you push your new changes since it is out of date |
|
@joshuahannan latest pull have taken and the return type also changed |
|
May need to fix the Go tests to make the CI happy |
joshuahannan
force-pushed
the
implementation-of-flip-69
branch
from
302c5ec
to
3c655f5
Compare
It addresses https://github.com/onflow/flips/blob/fungibleToken-standard-improvement/flips/20230206-fungible-token-vault-type-discovery.md
TODO: