Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFM] Dynamic Protocol State injects EpochExtension when entering EFM #5724

Closed
Tracked by #5732 ...
kc1116 opened this issue Apr 18, 2024 · 1 comment · Fixed by #5773
Closed
Tracked by #5732 ...

[EFM] Dynamic Protocol State injects EpochExtension when entering EFM #5724

kc1116 opened this issue Apr 18, 2024 · 1 comment · Fixed by #5773

Comments

@kc1116
Copy link
Contributor

kc1116 commented Apr 18, 2024

Context

The Dynamic Protocol State already detects and triggers EFM. It will also need to inject EpochExtensions when EFM is triggered, and on an ongoing basis while EFM remains triggered. When we enter EFM as a result of processing some block B, we switch to using the epochFallbackStateMachine to process subsequent blocks. Modify existing EFM triggering logic to simultaneously inject the first EpochExtension to the protocol state in block B.

This issue is for injecting the first EpochExtension (entering EFM). #5726 is for adding EpochExtensions on an ongoing basis (maintaining EFM). #5731 is for the detailed logic to avoid changing already committed leader selections.

Further Reading

Design

@kc1116 kc1116 added the S-BFT label Apr 18, 2024
@kc1116 kc1116 self-assigned this Apr 18, 2024
@franklywatson franklywatson added this to the EFM-Q2 milestone Apr 18, 2024
@durkmurder durkmurder self-assigned this Apr 19, 2024
@jordanschalm jordanschalm changed the title [EFM] Dynamic Protocol State EpochExtension injection [EFM] Dynamic Protocol State injects EpochExtension when entering EFM Apr 23, 2024
@kc1116 kc1116 removed their assignment Apr 23, 2024
@kc1116 kc1116 modified the milestones: EFM-Q2, EFM-Q2 Epoch Extensions updates Apr 23, 2024
@franklywatson franklywatson removed this from the EFM-Q2 EFM Core updates milestone Apr 23, 2024
@franklywatson franklywatson added this to the EFM-Q2 EFM Core updates milestone Apr 26, 2024
@durkmurder
Copy link
Member

Implemented in #5773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants