Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFM] Modify EFM logic do not enter EFM while in EpochCommitted phase #5731

Closed
kc1116 opened this issue Apr 18, 2024 · 3 comments
Closed

[EFM] Modify EFM logic do not enter EFM while in EpochCommitted phase #5731

kc1116 opened this issue Apr 18, 2024 · 3 comments

Comments

@kc1116
Copy link
Contributor

kc1116 commented Apr 18, 2024

Context

When entering EFM currently we will discard any partial data for a committed Epoch, we instead need to go through the committed epoch and enter EFM by adding an extension to the committed epoch. Modify EFM logic in the Protocol State Machine: do not enter EFM while in phase EpochCommitted.

Open Questions

It's an open question whether we should do this at all. See https://www.notion.so/flowfoundation/Spork-less-Epoch-Fallback-Recovery-Design-II-Epoch-Extensions-e923ca84b4d848c5a17de4b18fb5afd5?pvs=4#a5d27c278ec249cbb93784cedb7e7ec3

@AlexHentschel
Copy link
Member

see #5631 for more details

related issues:

@jordanschalm
Copy link
Member

Hey @durkmurder I think we can close this, right?

@jordanschalm
Copy link
Member

Closing as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants