update default values for epoch, staking and DKG length

[kc1116]

epoch length - 10000
staking length - 2000
DKG length - 2000

[codecov-commenter]

Codecov Report

Merging #1063 (149b7b6) into master (95c99c0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage   53.34%   53.36%   +0.01%     
==========================================
  Files         318      318              
  Lines       21556    21556              
==========================================
+ Hits        11500    11504       +4     
+ Misses       8484     8479       -5     
- Partials     1572     1573       +1     

Flag	Coverage Δ
unittests	53.36% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/util/ledger/migrations/storage_v4.go	41.56% <0.00%> (-0.61%)	⬇️
engine/common/synchronization/engine.go	64.01% <0.00%> (ø)
...sus/approvals/assignment_collector_statemachine.go	51.92% <0.00%> (+4.80%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c99c0...149b7b6. Read the comment docs.

[simonhf]

Just linking this issue to this sibling issue here: https://github.com/dapperlabs/flow-go/issues/5709

[huitseeker]

I've seen @jordanschalm mention non-zero defaults here.
I notice the default setup here:

flow-go/cmd/bootstrap/cmd/finalize.go

Lines 91 to 93 in f2547a2

	finalizeCmd.Flags().Uint64Var(&flagNumViewsInEpoch, "epoch-length", 4000, "length of each epoch measured in views")
	finalizeCmd.Flags().Uint64Var(&flagNumViewsInStakingAuction, "epoch-staking-phase-length", 100, "length of the epoch staking phase measured in views")
	finalizeCmd.Flags().Uint64Var(&flagNumViewsInDKGPhase, "epoch-dkg-phase-length", 1000, "length of each DKG phase measured in views")

which seems to be used in the absence of other instructions (other instructions you're setting here for localnet).
I haven't found a setting of 200 / 5/ 80.

QQ:

• do we want to change the general default or the one for localnet?
• Do we want these numbers, sp. for the staking phase length (usually 1/10 the DKG length)?
• Is there a 3d palce where @jordanschalm 's numbers are set?

[kc1116]

I've seen @jordanschalm mention non-zero defaults here.
I notice the default setup here:

flow-go/cmd/bootstrap/cmd/finalize.go

Lines 91 to 93 in f2547a2

	finalizeCmd.Flags().Uint64Var(&flagNumViewsInEpoch, "epoch-length", 4000, "length of each epoch measured in views")
	finalizeCmd.Flags().Uint64Var(&flagNumViewsInStakingAuction, "epoch-staking-phase-length", 100, "length of the epoch staking phase measured in views")
	finalizeCmd.Flags().Uint64Var(&flagNumViewsInDKGPhase, "epoch-dkg-phase-length", 1000, "length of each DKG phase measured in views")

which seems to be used in the absence of other instructions (other instructions you're setting here for localnet).
I haven't found a setting of 200 / 5/ 80.
QQ:

• do we want to change the general default or the one for localnet?
• Do we want these numbers, sp. for the staking phase length (usually 1/10 the DKG length)?
• Is there a 3d palce where @jordanschalm 's numbers are set?

• We are only changing the defaults for localnet in this PR to address flakiness in testing.
• Yes, these numbers give us the desired result on localnet when testing.
• For localnet no, these numbers are only set in the CLI defaults or by the makefile.

[huitseeker]

LGTM!